Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEED TO ADD NAVBAR AND FOOTER IN CONTRIBUTOR PAGE #3104 #3123

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

isimarjitsingh
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3104

πŸ‘¨β€πŸ’» Description

What does this PR do?

basicallly i added navbar and footer in this page

AS IT LOOKS LIKE A VERY EASY JOB BUT IT'S NOT BEACAUSE WHEN WE TRY TO GIVE NAVBAR AND FOOTER ON THIS WITH SIMPLE BASIS IT CHANGE THE WHOLE CONTENT OF PAGE LIKE CHANGES THE COLOR OF CARDS SO AT HERE I NEED TO FIND THAT PARTICULAR ELEMENTS AND I NEED TO GIVE INLINE CSS .

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

before:-
Screenshot 2024-11-09 172420

after:-
Screenshot 2024-11-09 171724
Screenshot 2024-11-09 171713

Copy link

vercel bot commented Nov 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 13 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link

github-actions bot commented Nov 9, 2024

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 9, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit aa82b0a
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/672f4d90db51260008c83caa
😎 Deploy Preview https://deploy-preview-3123--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 32
Accessibility: 63
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@isimarjitsingh
Copy link
Contributor Author

@sampadatiwari30 kindly give level2 as i mention the problems above

@deepeshmlgupta deepeshmlgupta merged commit b1940a0 into ayush-that:main Nov 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style]: NEED TO ADD NAVBAR AND FOOTER IN CONTRIBUTOR PAGE
2 participants