Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FD Calculator Buttons and Improve Accessibility with Legend #3337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akshay0611
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3336

πŸ‘¨β€πŸ’» Description

What does this PR do?

This pull request addresses the issue with the FD Calculator where the Calculate and Clear buttons are non-functional. After entering valid input for Principal, Rate of Interest, and Time Period, the buttons fail to trigger their intended actions:

  • The Calculate button does not perform the calculation or display any results.
  • The Clear button does not reset the input fields or remove the results.

This fix ensures that both buttons function as expected, providing the user with the ability to:

  • Calculate the total interest and maturity amount based on the entered values.
  • Clear the input fields and any displayed results.

Additionally, a legend has been added to the FD Calculator for better accessibility and context, helping users understand the purpose of each input section.

πŸ“„ Type of Change

  • [βœ… ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

Before the Fix:

The screenshot shows the FD Calculator interface with the Calculate and Clear buttons present. Despite entering valid values for Principal, Rate of Interest, and Time Period, clicking the Calculate button does not trigger any calculation or display results. Similarly, clicking the Clear button does not reset the input fields or clear the displayed results. The buttons are visually present but do not function as expected, resulting in a non-interactive user experience.

Screenshot 2024-11-25 at 8 47 31 AM

After the Fix:

The screenshot shows the FD Calculator interface after the fix has been implemented. Now, clicking the Calculate button correctly triggers the calculation of total interest and maturity amount, displaying the results as expected. The Clear button also functions as intended, resetting the input fields and clearing any displayed results, providing a fully interactive and responsive user experience.

Screenshot 2024-11-25 at 10 09 34 AM

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • [βœ… ] I have followed the contribution guidelines of this project.
  • [βœ… ] I have made this change from my own.
  • [] I have taken help from some online resources.
  • [βœ… ] My code follows the style guidelines of this project.
  • [βœ… ] I have performed a self-review of my own code.
  • [] I have added documentation to explain my changes.

Mandatory Tasks

  • [βœ… ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 25, 2024 4:43am

Copy link

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@akshay0611
Copy link
Contributor Author

Hi @ayush-that ,

I hope you're doing well! I wanted to follow up on this pull request addressing Issue #3336. It resolves the non-functional Calculate and Clear buttons in the FD Calculator and includes improvements like adding a legend for better accessibility.

Apart from this, I’ve also made other contributions to the repository that enhance its functionality and user experience. I would greatly appreciate it if you could review those changes as well.

Please let me know if there's any feedback or additional adjustments required. Your time and effort in reviewing my contributions mean a lotβ€”thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: FD Calculator Buttons Not Functioning
1 participant