Skip to content

Commit

Permalink
remove negative checks for box_shape
Browse files Browse the repository at this point in the history
  • Loading branch information
mat-1 committed Jan 20, 2025
1 parent 2dcfbe9 commit aef29da
Showing 1 changed file with 3 additions and 18 deletions.
21 changes: 3 additions & 18 deletions azalea-physics/src/collision/shape.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,9 @@ pub fn box_shape(
max_y: f64,
max_z: f64,
) -> VoxelShape {
assert!(min_x >= 0., "min_x must be >= 0 but was {min_x}");
assert!(min_y >= 0.);
assert!(min_z >= 0.);
assert!(max_x >= 0.);
assert!(max_y >= 0.);
assert!(max_z >= 0.);

box_shape_unchecked(min_x, min_y, min_z, max_x, max_y, max_z)
}
// we don't check for the numbers being out of bounds because some blocks are
// weird and are outside 0-1

pub fn box_shape_unchecked(
min_x: f64,
min_y: f64,
min_z: f64,
max_x: f64,
max_y: f64,
max_z: f64,
) -> VoxelShape {
if max_x - min_x < EPSILON && max_y - min_y < EPSILON && max_z - min_z < EPSILON {
return EMPTY_SHAPE.clone();
}
Expand Down Expand Up @@ -591,7 +576,7 @@ impl VoxelShape {

impl From<AABB> for VoxelShape {
fn from(aabb: AABB) -> Self {
box_shape_unchecked(
box_shape(
aabb.min.x, aabb.min.y, aabb.min.z, aabb.max.x, aabb.max.y, aabb.max.z,
)
}
Expand Down

0 comments on commit aef29da

Please sign in to comment.