support defining a dimension field as multi-valued #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to address #56, azaurus1/go-pinot-api#126 introduced
singleValueField
schema's property management.The current PR refers to bumping
go-pinot-api
version to 0.3.0, allowing terraform provider to manage the property in question. Since this is a configuration for dimension fields only, I'm also suggesting the splittingfieldSpec
indimensionFieldSpec
andmetricFieldSpec
.Other than that, I also needed to refactor
notNull
property usage, given json encoder limitation @gbrlcustodio mentioned in azaurus1/go-pinot-api#126 when it comes to omitted falsy values.Please be thoughtful about this being my first go at Golang 🥁, so probably this one requires a thorough review before moving on. 😅