Do not require every plugin recorded in the model bundle to be installed when using it #1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The model bundles record every rastervision plugin that was installed when they were created. Previously, it was required to have all those plugins installed when using those bundles even if not actually needed or otherwise an error would be raised. This has been especially relevant ever since
rastervision_gdal_vsi
was made optional and not included in the default pip install--meaning users would not have been able to use bundles from the model zoo without installingrastervision_gdal_vsi
first.This PR removes this requirement. Now, the missing plugins are just logged as a warning and no error is raised.
This PR completes a task in #960.
To reproduce:
The above runs into an error complaining about
rastervision_gdal_vsi
being missing.Checklist
needs-backport
label if PR is bug fix that applies to previous minor releaseNotes
N/A
Testing Instructions