Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CI/Codestyle): check for curly brackets before/after if/else statements #20977

Merged
merged 9 commits into from
Dec 19, 2024
Merged

feat(CI/Codestyle): check for curly brackets before/after if/else statements #20977

merged 9 commits into from
Dec 19, 2024

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Dec 19, 2024 •
edited
Loading

Output in current AC
image

@Kitzunu Kitzunu requested a review from Grimdhex December 19, 2024 19:31
@Kitzunu Kitzunu added the run-build Used to trigger the windows/mac/docker and matrix builds label Dec 19, 2024
@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Dec 19, 2024
Grimdhex
Grimdhex requested changes Dec 19, 2024
View reviewed changes
apps/codestyle/codestyle.py Outdated Show resolved Hide resolved
@Kitzunu Kitzunu requested a review from Grimdhex December 19, 2024 19:51
@Kitzunu Kitzunu changed the title feat(CI/Codestyle): check for braces after if/else statements feat(CI/Codestyle): check for curly brackets after if/else statements Dec 19, 2024
@Kitzunu Kitzunu changed the title feat(CI/Codestyle): check for curly brackets after if/else statements feat(CI/Codestyle): check for curly brackets before/after if/else statements Dec 19, 2024
@Kitzunu Kitzunu merged commit ceefd89 into azerothcore:master Dec 19, 2024
13 of 18 checks passed
@Kitzunu Kitzunu deleted the codestyle-fun-stuff branch December 19, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grimdhex Grimdhex Grimdhex approved these changes

@sudlud sudlud sudlud approved these changes

Assignees
No one assigned
Labels
CORE Related to the core file-cpp Used to trigger the matrix build run-build Used to trigger the windows/mac/docker and matrix builds Script To Be Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kitzunu @sudlud @Grimdhex