Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore. Prevent tanks and heals in config #50

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

pangolp
Copy link

@pangolp pangolp commented Mar 17, 2024

Changes Proposed:

  • The idea of the pull request is to prevent tanks and heals from scoring arenas, however, it is a configurable option, and by default it is disabled. Within the configuration file, each server will be able to choose whether it wants to enable one or both, or neither.
  • The functionality of counting the number of talents and limiting it by the number of talents remains to be implemented, but that is a matter for another pull request.

Issues Addressed:

SOURCE:

Tests Performed:

  • Windows 10
  • In-game

How to Test the Changes:

  1. Score sands as normal and test.
  2. Add a heal talent and enable the configuration file option, you will see that it will not let you score.
  3. Repeat the process for the tank branch, it should not stop either, if the option is set to true.
  4. Both options are disabled by default.

@pangolp pangolp merged commit 27ba171 into azerothcore:master Mar 17, 2024
1 check passed
@pangolp pangolp deleted the chor branch March 17, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still not working Forbidden Talents!
1 participant