Skip to content

Commit

Permalink
fix: update error message for invalid build preset (#396)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcbsfilho authored Oct 16, 2024
1 parent 6738ca6 commit 6ac6159
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 6 additions & 2 deletions lib/build/dispatcher/dispatcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,15 @@ class Dispatcher {
*/
async loadPreset() {
const VALID_BUILD_PRESETS = presets.getKeys();

const originalPresetName = this.preset.name;
// e.g. accept 'javascript' and 'JavaScript'
this.preset.name = this.preset.name.toLowerCase();
const validPreset = VALID_BUILD_PRESETS.includes(this.preset.name);

if (!validPreset) {
feedback.build.error(Messages.build.error.invalid_preset);
feedback.build.error(
Messages.build.error.invalid_preset(originalPresetName),
);
process.exit(1);
}

Expand Down
4 changes: 2 additions & 2 deletions lib/constants/messages/build.messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ const build = {
},
error: {
vulcan_build_failed: 'Azion build failed.',
invalid_preset:
'Invalid build preset. Run "azion preset ls" to view available presets.',
invalid_preset: (preset) =>
`Invalid build preset name: '${preset}'. Run "npx edge-functions presets ls" to view available presets.`,
invalid_preset_mode: (mode, preset) =>
`Mode '${mode}' does not exists in preset '${preset}'. Try 'deliver' or 'compute'.`,
prebuild_error_validation_support: (framework, version, runtimes) =>
Expand Down

0 comments on commit 6ac6159

Please sign in to comment.