Ensure goto is relative to the root path
#163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dired views have a root (on `self.path`) and then possibly a `goto` path which is some file below the root. Ensure the constructor `DiredCommand` sets a relative `goto` path, otherwise all folders up to the file system root will be watched. While navigating, `goto` was always relative to the view's root already, so only `DiredCommand` needs to be changed. See also the doc for `DiredRefreshCommand.expand_goto` which clearly assumes relative paths for `self.goto`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dired views have a root (on
self.path) and then possibly agotopath which is some file below the root.Ensure the constructor
DiredCommandsets a relativegotopath, otherwise all folders up to the file system root will be watched. (!)While navigating,
gotowas always relative to the view's root already, so onlyDiredCommandneeds to be changed.See also the doc for
DiredRefreshCommand.expand_gotowhich clearly assumes relative paths forself.goto.