Removed conditional return

azjezz · Dec 25, 2023 · 3e71e52 · 3e71e52
1 parent 0d8529b
commit 3e71e52
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/Psl/Option/Option.php b/src/Psl/Option/Option.php
@@ -315,11 +315,7 @@ public function equals(mixed $other): bool
      *
      * @param Option<Tu> $other The other `Option` to zip with.
      *
-     * @return (
-     *     T is never
-     *     ? Option<never>
-     *     : (Tu is never ? Option<never> : Option<array{T, Tu}>)
-     * )
+     * @return Option<array{T, Tu}> The resulting `Option` containing the combined tuple or `None`.
      */
     public function zip(Option $other): Option
     {

diff --git a/tests/static-analysis/Option/zip.php b/tests/static-analysis/Option/zip.php
@@ -6,15 +6,15 @@
 use Psl\Type;
 
 /**
- * @return Option\Option<never>
+ * @return Option\Option<array{never, int}>
  */
 function test_partial_none_tuple_1(): Option\Option
 {
     return Option\none()->zip(Option\some(1));
 }
 
 /**
- * @return Option\Option<never>
+ * @return Option\Option<array{int, never}>
  */
 function test_partial_none_tuple_2(): Option\Option
 {
@@ -24,7 +24,7 @@ function test_partial_none_tuple_2(): Option\Option
 /**
  * @throws Type\Exception\AssertException
  *
- * @return array{Option\Option<never>, Option\Option<never>}
+ * @return array{Option\Option<never>, Option\Option<int>}
  */
 function test_partial_none_unzip_1(): array
 {
@@ -42,7 +42,7 @@ function test_some_zip(): Option\Option
 /**
  * @throws Type\Exception\AssertException
  *
- * @return array{Option\Option<never>, Option\Option<never>}
+ * @return array{Option\Option<int>, Option\Option<never>}
  */
 function test_partial_none_unzip_2(): array
 {