Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arr] deprecate duplicated functions #124

Merged
merged 1 commit into from
Feb 16, 2021
Merged

[Arr] deprecate duplicated functions #124

merged 1 commit into from
Feb 16, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 16, 2021 •
edited
Loading

ref #120

changelog:

Deprecations:

  • deprecated Psl\Arr\contains ( use Psl\Iter\contains instead )
  • deprecated Psl\Arr\contains_key ( use Psl\Iter\contains_key instead )
  • deprecated Psl\Arr\count ( use Psl\Iter\count instead )
  • deprecated Psl\Arr\count_values ( use Psl\Dict\count_values instead )
  • deprecated Psl\Arr\first ( use Psl\Iter\first instead )
  • deprecated Psl\Arr\firstx ( use Psl\Iter\first instead )
  • deprecated Psl\Arr\first_key ( use Psl\Iter\first_key instead )
  • deprecated Psl\Arr\last ( use Psl\Iter\last instead )
  • deprecated Psl\Arr\lastx ( use Psl\Iter\last instead )
  • deprecated Psl\Arr\last_key ( use Psl\Iter\last_key instead )
  • deprecated Psl\Arr\idx ( use $array|$key] ?? $default instead )
  • deprecated Psl\Arr\at ( use $array[$key] instead )
  • deprecated Psl\Iter\enumerate ( use Psl\Vec\enumerate instead )

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Feb 16, 2021
@azjezz azjezz self-assigned this Feb 16, 2021
@azjezz azjezz added this to the 1.2.0 milestone Feb 16, 2021
@coveralls
Copy link

coveralls commented Feb 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 570113775

  • 81 of 81 (100.0%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0002%) to 99.957%
Totals Coverage Status
Change from base Build 569972055: 0.0002%
Covered Lines: 2301
Relevant Lines: 2302
💛 - Coveralls

@azjezz azjezz merged commit 434da8e into 1.2.x Feb 16, 2021
@azjezz azjezz deleted the deprecation/arr branch February 16, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls