Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Class, Trait, and Interface components #138

Merged
merged 2 commits into from
May 14, 2021
Merged

Introduce Class, Trait, and Interface components #138

merged 2 commits into from
May 14, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 21, 2021

closes #59

changelog:

  • dropped support for PHP 7.4
  • Introduced Class component
  • Introduced Interface component
  • Introduced Trait component

@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes. labels Feb 21, 2021
@azjezz azjezz added this to the 1.5.0 milestone Feb 21, 2021
@azjezz azjezz requested a review from veewee February 21, 2021 01:26
@azjezz azjezz self-assigned this Feb 21, 2021
@coveralls
Copy link

coveralls commented Feb 21, 2021

Pull Request Test Coverage Report for Build 842835950

  • 15 of 15 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 793964690: 0.0%
Covered Lines: 2999
Relevant Lines: 2999

💛 - Coveralls

src/Psl/ObjectOriented/class_alias.php Outdated Show resolved Hide resolved
src/Psl/ObjectOriented/class_alias.php Outdated Show resolved Hide resolved
src/Psl/ObjectOriented/class_exists.php Outdated Show resolved Hide resolved
src/Psl/ObjectOriented/class_exists.php Outdated Show resolved Hide resolved
src/Psl/ObjectOriented/get_class.php Outdated Show resolved Hide resolved
@azjezz azjezz modified the milestones: 1.5.0, 1.6.0 Mar 19, 2021
@azjezz azjezz changed the base branch from 1.5.x to 1.6.x March 19, 2021 04:13
@azjezz azjezz modified the milestones: 1.6.0, 1.7.0 Apr 7, 2021
@Ocramius
Copy link
Contributor

Ocramius commented May 11, 2021 via email

@azjezz
Copy link
Owner Author

azjezz commented May 11, 2021

ugh, now i'm not sure if either Class, Object, or ClassName make sense since the namespace also contains functions that deal with traits and interfaces ( interface_exists, trait_exists .. etc )

@Ocramius
Copy link
Contributor

Ocramius commented May 11, 2021 via email

@azjezz
Copy link
Owner Author

azjezz commented May 11, 2021

Psl\Class\exists, Psl\Interface\exists, Psl\Trait\exits? seems like an overkill to have a separate component for just one function.

maybe Psl\Runtime\class_exists? ( as in "check if the class exists at runtime )? ( the component would definitely contain other functions related to PHP runtime )

@Ocramius
Copy link
Contributor

What's "runtime"?

@azjezz
Copy link
Owner Author

azjezz commented May 11, 2021

the time when things run :p

@Ocramius
Copy link
Contributor

Oh, that's how a German would read it, not an English speaker :P

Anyway, I would not call it Runtime, as Runtime would be more about things like env(), running processes, etc. Don't see a big problem in having isolated namespaces. Don't have any better suggestions, and ObjectOriented, as wonky as it sounds, is still better than Runtime at this point.

@azjezz azjezz force-pushed the feature/obj branch 2 times, most recently from e858b11 to be66807 Compare May 14, 2021 14:41
@azjezz
Copy link
Owner Author

azjezz commented May 14, 2021

update: PHP 7.4 support is dropped, now split into 3 components: Class, Trait, and Interface

@azjezz azjezz changed the title [ObjectOriented] Introduce ObjectOriented component Introduce Class, Trait, and Interface components May 14, 2021
@azjezz azjezz changed the base branch from 1.6.x to 1.7.x May 14, 2021 14:53
@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed. labels May 14, 2021
@azjezz azjezz merged commit cdadc62 into 1.7.x May 14, 2021
@azjezz azjezz deleted the feature/obj branch May 14, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects API
5 participants