-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Class, Trait, and Interface components #138
Conversation
Pull Request Test Coverage Report for Build 842835950
💛 - Coveralls |
Instead of introducing a breakage just for being able to use `Class\`, may
I suggest `ClassName\`? 😛
…On Tue, May 11, 2021, 08:54 Saif Eddin Gmati ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Psl/ObjectOriented/class_alias.php
<#138 (comment)>:
> @@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Psl\ObjectOriented;
My IDE will autocomplete the namespace, so I don't mind that it is named
object-oriented. That much.
personally i don't import symbols, but rather namespaces most of the time.
so it's:
use Psl\Class;
if (Class\exists($foo)) {
...
}
rather than:
use function Psl\Class\exists;
if (exists($foo)) {
...
}
and here Class\exists($foo) reads better than
ObjectOriented\class_exists($foo) ( and definitly better than exists($foo)
).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEH2QCUGHVUFUKMGJDLTNDID5ANCNFSM4X6OG3SA>
.
|
ugh, now i'm not sure if either |
`exists()` could be the function name 😛
…On Tue, May 11, 2021, 09:22 Saif Eddin Gmati ***@***.***> wrote:
ugh, now i'm not sure if either Class, Object, or ClassName make sense
since the namespace also contains functions that deal with traits and
interfaces ( interface_exists, trait_exists .. etc )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEHWBVXGLJ2SSUZ7SOLTNDLMFANCNFSM4X6OG3SA>
.
|
maybe |
What's "runtime"? |
the time when things run :p |
Oh, that's how a German would read it, not an English speaker :P Anyway, I would not call it |
e858b11
to
be66807
Compare
update: PHP 7.4 support is dropped, now split into 3 components: Class, Trait, and Interface |
closes #59
changelog:
Class
componentInterface
componentTrait
component