Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/variadic intersection type #185

Merged
merged 17 commits into from
Apr 28, 2021
Merged

Feature/variadic intersection type #185

merged 17 commits into from
Apr 28, 2021

Conversation

nzour
Copy link
Contributor

@nzour nzour commented Apr 27, 2021

Union variadic types issue #183 and PR #184

nzour and others added 13 commits April 26, 2021 23:07
@nzour
Psl\Type\union - renamed parameters: left_type -> first, right_type -…
e8778ab 
…> second
@nzour
Psl\Type\union - added variadic parameter $rest
6a80f71
@nzour
Improving tests for UnionType
41c9cf6
@nzour
Added static-analysis tests for union type
49b6989
@nzour
cs fix: static-analysis test for union
94223e6
@nzour
Psl\Type\literal_scalar simplified union type definition
1b7c8dc
@nzour
Psl\Type\intersection renamed function parameters: left_type -> first…
3344eb5 
…, right_type -> second
@nzour
Psl\Type\intersection added variadic third parameter
a1d0e94
@nzour
Psl\Type\intersection cs fix
72c1249
@nzour
Added static analysis tests for intersection
3519ead
@nzour
Merge pull request #1 from azjezz/1.7.x
5d47fa6 
[Type] add support for variadic union types (azjezz#184)
@nzour
Merge branch '1.7.x' into feature/variadic-intersection-type
fa5e6a3
@nzour
Static analysis test for intersection - removed redundant psalm-suppress
adf1ec3
@coveralls
Copy link

coveralls commented Apr 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 793953391

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 790211348: 0.0%
Covered Lines: 2988
Relevant Lines: 2988
💛 - Coveralls

@azjezz
Copy link
Owner

azjezz commented Apr 27, 2021

could you please add a unit test to create an intersection with more than 2 types? ( to keep code coverage the same )

@azjezz azjezz linked an issue Apr 27, 2021 that may be closed by this pull request
Union for variadic types #183
Closed
@azjezz azjezz added this to the 1.7.0 milestone Apr 27, 2021
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes. labels Apr 27, 2021
@nzour
Copy link
Contributor Author

nzour commented Apr 27, 2021

could you please add a unit test to create an intersection with more than 2 types? ( to keep code coverage the same )

Yep, I'll do it

azjezz
azjezz reviewed Apr 28, 2021
View reviewed changes
tests/unit/Type/IntersectionTypeTest.php
Comment on lines +79 to +84
Type\intersection(
Type\object(IndexAccessInterface::class),
Type\object(CollectionInterface::class),
Type\object(Iterator::class),
Type\shape(['id' => Type\string()]),
),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically an impossible type, but okay :p

@azjezz azjezz merged commit 336653f into azjezz:1.7.x Apr 28, 2021
@azjezz
Copy link
Owner

azjezz commented Apr 28, 2021

Thank you @zour228 !

@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@azjezz azjezz

@nzour nzour

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Union for variadic types
3 participants
@nzour @coveralls @azjezz