Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't perform operations on possible numeric-string #220

Merged
merged 1 commit into from
Jul 24, 2021
Merged

Don't perform operations on possible numeric-string #220

merged 1 commit into from
Jul 24, 2021

Conversation

orklah
Copy link
Contributor

@orklah orklah commented Jul 24, 2021

This PR remove the possibility to perform operations on numeric-strings. This should prevent build failure in case this(vimeo/psalm#6169) or this(vimeo/psalm#6167) is merged in Psalm

@azjezz azjezz self-assigned this Jul 24, 2021
@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes. labels Jul 24, 2021
@azjezz azjezz added this to the 1.8.0 milestone Jul 24, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1062235439

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.903%
Totals Coverage Status
Change from base Build 1018650183: 0.0%
Covered Lines: 3102
Relevant Lines: 3105
💛 - Coveralls

@azjezz
Copy link
Owner

azjezz commented Jul 24, 2021

hm, psalm failure seems unrelated, but also new 🤔 we can ignore it for now.

@azjezz azjezz added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jul 24, 2021
@azjezz azjezz merged commit 4895e61 into azjezz:1.8.x Jul 24, 2021
@azjezz
Copy link
Owner

azjezz commented Jul 24, 2021

Thank you @orklah 🎉

@azjezz azjezz mentioned this pull request Jul 24, 2021
Merged
azjezz pushed a commit that referenced this pull request Aug 25, 2021
@orklah @azjezz
[Math] don't perform operations on possible numeric-string (#220)
0f6d03d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@orklah @coveralls @azjezz