Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(async): throw if resource is closed while waiting #256

Merged
merged 1 commit into from
Nov 6, 2021
Merged

feat(async): throw if resource is closed while waiting #256

merged 1 commit into from
Nov 6, 2021
+54 −21

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 6, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 6, 2021
@azjezz azjezz added this to the 2.0.0 milestone Nov 6, 2021
@azjezz azjezz self-assigned this Nov 6, 2021
@azjezz azjezz force-pushed the feature/throw-on-close branch from 3688e72 to 09bebca Compare November 6, 2021 08:25
@coveralls
Copy link

coveralls commented Nov 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1428703385

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1428407409: 0.0%
Covered Lines: 3073
Relevant Lines: 3073
💛 - Coveralls

@azjezz azjezz force-pushed the feature/throw-on-close branch from 09bebca to 5e2694b Compare November 6, 2021 08:33
@azjezz
feat(async): throw if resource is closed while waiting
5e2694b 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz merged commit b5f2ef8 into 2.0.x Nov 6, 2021
@azjezz azjezz deleted the feature/throw-on-close branch November 6, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls