Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(io/tcp/unix): improve performance, and closed handle/server condition #264

Merged
merged 1 commit into from
Nov 10, 2021
Merged

chore(io/tcp/unix): improve performance, and closed handle/server condition #264

merged 1 commit into from
Nov 10, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 10, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Nov 10, 2021
@azjezz azjezz added this to the 2.0.0 milestone Nov 10, 2021
@azjezz azjezz self-assigned this Nov 10, 2021
@azjezz azjezz force-pushed the chore/cancel-on-close branch from 1837483 to 24d93a8 Compare November 10, 2021 07:36
@coveralls
Copy link

coveralls commented Nov 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1443101923

  • 58 of 66 (87.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 99.751%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Psl/TCP/Server.php 30 34 88.24%
src/Psl/Unix/Server.php 28 32 87.5%
Totals Coverage Status
Change from base Build 1433664692: -0.2%
Covered Lines: 3204
Relevant Lines: 3212
💛 - Coveralls

@azjezz azjezz force-pushed the chore/cancel-on-close branch 4 times, most recently from 9096b4d to 57eff73 Compare November 10, 2021 07:45
@azjezz
chore(io/tcp/unix): improve performance, and closed handle/server con…
85b1814 
…dition

Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the chore/cancel-on-close branch from 57eff73 to 85b1814 Compare November 10, 2021 08:39
@azjezz azjezz merged commit e7d46a5 into 2.0.x Nov 10, 2021
@azjezz azjezz deleted the chore/cancel-on-close branch November 10, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls