Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(io): do not throw on non-blocking resource #267

Merged
merged 1 commit into from
Nov 10, 2021
Merged

chore(io): do not throw on non-blocking resource #267

merged 1 commit into from
Nov 10, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 10, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz
chore(io): do not throw on non-blocking resource
a848d33 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 10, 2021
@azjezz azjezz added this to the 2.0.0 milestone Nov 10, 2021
@azjezz azjezz self-assigned this Nov 10, 2021
@azjezz
Copy link
Owner Author

azjezz commented Nov 10, 2021

helps with windows support.

@azjezz azjezz merged commit 740c8e3 into 2.0.x Nov 10, 2021
@azjezz azjezz deleted the fix/non-blocking branch November 10, 2021 19:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1445769403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1444858447: 0.0%
Covered Lines: 3206
Relevant Lines: 3206
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls