Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(io): do not throw already closed exception when closing twice #274

Merged
merged 1 commit into from
Nov 13, 2021
Merged

chore(io): do not throw already closed exception when closing twice #274

merged 1 commit into from
Nov 13, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 13, 2021

No description provided.

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 13, 2021
@azjezz azjezz added this to the 2.0.0 milestone Nov 13, 2021
@azjezz azjezz self-assigned this Nov 13, 2021
@coveralls
Copy link

coveralls commented Nov 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1457263630

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 100.0%
Totals Coverage Status
Change from base Build 1457213924: 0.06%
Covered Lines: 3210
Relevant Lines: 3210
💛 - Coveralls

@azjezz
chore(io): do not throw already closed exception when closing twice
d7417a2 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the chore/do-not-throw-on-close branch from 919bf37 to d7417a2 Compare November 13, 2021 20:07
@azjezz azjezz merged commit 26dbdb9 into 2.0.x Nov 13, 2021
@azjezz azjezz deleted the chore/do-not-throw-on-close branch November 13, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls