Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(io): do not throw on close. #296

Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix(io): do not throw on close. #296

merged 1 commit into from
Dec 2, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Dec 2, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz
fix(io): do not throw on close.
c45790a 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Dec 2, 2021
@azjezz azjezz added this to the 2.0.0 milestone Dec 2, 2021
@azjezz azjezz self-assigned this Dec 2, 2021
@azjezz azjezz merged commit 1d74c20 into 2.0.x Dec 2, 2021
@azjezz azjezz deleted the fix/io-close branch December 2, 2021 15:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1531154171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.97%
Totals Coverage Status
Change from base Build 1531147513: 0.0%
Covered Lines: 3315
Relevant Lines: 3316
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls