Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(composer): add Psl namespace mapped to src/Psl #311

Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix(composer): add Psl namespace mapped to src/Psl #311

merged 1 commit into from
Dec 10, 2021

Conversation

asgrim
Copy link

@asgrim asgrim commented Dec 10, 2021

Fixes #310

Tools such as maglnet/ComposerRequireChecker rely on symbols being autoloadable, but due to the way the autoloader works here, it seems the symbols can't be picked up. The issue does not affect 2.0.x-dev since the path src/Psl is mapped in composer.json, so the symbols are able to be loaded. So this path map is backported to 1.9.x series, so that tools that
work in this way can see the Psl\* functions.

@asgrim
Adds Psl namespace mapped to src/Psl
c724a6e 
Fixes azjezz#310

Tools such as `maglnet/ComposerRequireChecker` rely on symbols being
autoloadable, but due to the way the autoloader works here, it seems the
symbols can't be picked up. The issue does not affect `2.0.x-dev` since the
path `src/Psl` is mapped in `composer.json`, so the symbols are able to be
loaded. So this path map is backported to `1.9.x` series, so that tools that
work in this way can see the `Psl\*` functions.
@asgrim asgrim mentioned this pull request Dec 10, 2021
Closed
@azjezz azjezz changed the title Adds Psl namespace mapped to src/Psl fix(composer): add Psl namespace mapped to src/Psl Dec 10, 2021
@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Dec 10, 2021
@azjezz azjezz merged commit 5c20649 into azjezz:1.9.x Dec 10, 2021
@asgrim asgrim deleted the 310-add-psl-to-composer-json branch December 10, 2021 10:35
@azjezz azjezz linked an issue Dec 10, 2021 that may be closed by this pull request
Feature - support for maglnet/ComposerRequireChecker #310
Closed
@azjezz azjezz added this to the 1.9.0 milestone Dec 10, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1562973595

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.936%
Totals Coverage Status
Change from base Build 1445903341: 0.0%
Covered Lines: 3132
Relevant Lines: 3134
💛 - Coveralls

@Ocramius Ocramius mentioned this pull request Dec 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@asgrim asgrim

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Feature - support for maglnet/ComposerRequireChecker
3 participants
@asgrim @coveralls @azjezz