Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iter): optimize iterator #318

Merged
merged 1 commit into from
Dec 19, 2021
Merged

chore(iter): optimize iterator #318

merged 1 commit into from
Dec 19, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Dec 19, 2021

No description provided.

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Dec 19, 2021
@azjezz azjezz added this to the 2.0.0 milestone Dec 19, 2021
@azjezz azjezz self-assigned this Dec 19, 2021
@azjezz azjezz force-pushed the fix/optimize-iter-iterator branch 2 times, most recently from a9a9f72 to 493463e Compare December 19, 2021 22:46
@coveralls
Copy link

coveralls commented Dec 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1599693590

  • 31 of 31 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0002%) to 99.879%
Totals Coverage Status
Change from base Build 1599373817: -0.0002%
Covered Lines: 3315
Relevant Lines: 3319
💛 - Coveralls

drupol
drupol reviewed Dec 19, 2021
View reviewed changes
Copy link

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a minor note.

src/Psl/Iter/Iterator.php Outdated Show resolved Hide resolved
src/Psl/Iter/Iterator.php Show resolved Hide resolved
@azjezz
chore(iter): optimize iterator
0081217 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the fix/optimize-iter-iterator branch from 493463e to 0081217 Compare December 19, 2021 22:53
@azjezz azjezz merged commit 3a9dcb9 into 2.0.x Dec 19, 2021
@azjezz azjezz deleted the fix/optimize-iter-iterator branch December 19, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol left review comments

Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@azjezz @coveralls @drupol