Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(collection): throw out-of-bounds exception instead of invariant violation for invalid offset #321

Merged
merged 1 commit into from
Dec 21, 2021
Merged

chore(collection): throw out-of-bounds exception instead of invariant violation for invalid offset #321

merged 1 commit into from
Dec 21, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Dec 21, 2021 •
edited
Loading

as part of #198

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. Type: BC Break A change that will result in a backward compatibility break in the public API. labels Dec 21, 2021
@azjezz azjezz added this to the 2.0.0 milestone Dec 21, 2021
@azjezz azjezz self-assigned this Dec 21, 2021
@azjezz azjezz force-pushed the chore/collection-out-of-bounds branch 3 times, most recently from 7d64df6 to abee22d Compare December 21, 2021 20:36
@azjezz
chore(collection): throw out-of-bounds exception instead of invariant…
abee22d 
… violation for invalid offset

Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz merged commit 07f8f2e into 2.0.x Dec 21, 2021
@azjezz azjezz deleted the chore/collection-out-of-bounds branch December 21, 2021 20:42
@coveralls
Copy link

coveralls commented Dec 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1608580694

  • 24 of 24 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0002%) to 99.88%
Totals Coverage Status
Change from base Build 1608376600: 0.0002%
Covered Lines: 3333
Relevant Lines: 3337
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: BC Break A change that will result in a backward compatibility break in the public API. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls