chore(filesystem): rework exceptions #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
added
Priority: High
azjezz
force-pushed
the
chore/filesystem/rework-exceptions
branch
from
19946cd to
19bcdab
Compare
Pull Request Test Coverage Report for Build 1632893479
💛 - Coveralls |
Signed-off-by: azjezz <azjezz@protonmail.com>
azjezz
force-pushed
the
chore/filesystem/rework-exceptions
branch
from
19bcdab to
ee42346
Compare
jrmajor
reviewed
Dec 30, 2021
Comment on lines
23
to
24
| * @throws Psl\Exception\InvariantViolationException If $directory doesn't exist or is not writable. | ||
| * @throws Psl\Exception\InvariantViolationException If $prefix contains a directory separator. |
There was a problem hiding this comment.
I think these cases are already covered by NotFoundException and InvalidArgumentException, except for “is not writable” part.
There was a problem hiding this comment.
working on a PR to rework exceptions for File component as well, this is just done to satisfy psalm :)
Comment on lines
+18
to
+19
| * @throws Filesystem\Exception\RuntimeException If unable to create the file. | ||
| * @throws Filesystem\Exception\RuntimeException If unable to create the file. |
| * @throws Psl\Exception\InvariantViolationException If the file specified by | ||
| * $filename does not exist. | ||
| * @throws Exception\NotFileException If $file is not a file. | ||
| * @throws Exception\NotFoundException If $file is not a found. |
There was a problem hiding this comment.
Suggested change
| * @throws Exception\NotFoundException If $file is not a found. | |
| * @throws Exception\NotFoundException If $file is not found. |
| @@ -14,17 +14,19 @@ | |||
| * | |||
| * In other environments, it is the forward slash `/`. | |||
| * | |||
| * @param string|null $suffix If the filename ends in a suffix, this will also be cut off. | |||
| * @param non-empty-string|null $suffix If the filename ends in a suffix, this will also be cut off. | |||
There was a problem hiding this comment.
Why suffix can not be an empty string?
There was a problem hiding this comment.
provide null in that case ^^ otherwise, it's useless ( this is done to encourage better typing down stream for users, so they know when they have a non-empty-string/empty-string. )
There was a problem hiding this comment.
Wouldn't string $suffix = '' be more convinient for users? $maybeNull ?? '' is easier to do than $maybeEmpty === '' ? null : $maybeEmpty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #198