Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): support idle connections #338

Merged
merged 1 commit into from
Feb 25, 2022
Merged

feat(network): support idle connections #338

merged 1 commit into from
Feb 25, 2022

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 25, 2022

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz
feat(network): support idle connections
47d4e5e 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Feb 25, 2022
@azjezz azjezz added this to the 2.0.0 milestone Feb 25, 2022
@azjezz azjezz self-assigned this Feb 25, 2022
@azjezz azjezz merged commit 2c9040e into 2.0.x Feb 25, 2022
@azjezz azjezz deleted the feat/network/idle-connections-support branch February 25, 2022 18:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1900306660

  • 23 of 28 (82.14%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 99.444%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Psl/TCP/ServerOptions.php 3 4 75.0%
src/Psl/Network/Internal/AbstractStreamServer.php 16 20 80.0%
Totals Coverage Status
Change from base Build 1898787793: -0.09%
Covered Lines: 3218
Relevant Lines: 3236
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls