Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Filesystem\get_extension() returning empty string #350

Merged
merged 1 commit into from
May 30, 2022
Merged

Fix Filesystem\get_extension() returning empty string #350

merged 1 commit into from
May 30, 2022

Conversation

dragosprotung
Copy link
Contributor

Fixes #349

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2410341839

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0003%) to 98.923%
Totals Coverage Status
Change from base Build 2309893504: 0.0003%
Covered Lines: 3308
Relevant Lines: 3344
💛 - Coveralls

@dragosprotung
Copy link
Contributor Author

I am not sure if we should handle more exception cases like test. (extension is only whitespace - yes unfortunatly it's possible) or test. x (extension contains some white space).

@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels May 30, 2022
@azjezz azjezz merged commit 11353b6 into azjezz:2.0.x May 30, 2022
@dragosprotung dragosprotung deleted the fix/get_extension branch May 30, 2022 19:54
@dragosprotung dragosprotung mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@dragosprotung dragosprotung

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragosprotung @coveralls @azjezz