Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support psalm v5 #369

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Support psalm v5 #369

merged 1 commit into from
Dec 1, 2022

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Nov 30, 2022 •
edited
Loading

Psalm v5 is out!

This PR contains:

Awaiting:

veewee
veewee commented Nov 30, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3586791947

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.977%
Totals Coverage Status
Change from base Build 3554970584: 0.0%
Covered Lines: 3386
Relevant Lines: 3421
💛 - Coveralls

@veewee veewee force-pushed the psalmv5 branch 3 times, most recently from 8f9ea80 to ffad6f0 Compare November 30, 2022 15:15
@veewee veewee changed the title [WIP] Support psalm v5 Support psalm v5 Nov 30, 2022
@veewee veewee requested a review from azjezz November 30, 2022 18:49
azjezz
azjezz previously approved these changes Nov 30, 2022
View reviewed changes
Copy link
Owner

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@veewee veewee added Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes. labels Dec 1, 2022
@veewee veewee changed the base branch from 2.2.x to 2.3.x December 1, 2022 06:19
@veewee veewee dismissed azjezz’s stale review December 1, 2022 06:19

The base branch was changed.

@veewee veewee requested a review from azjezz December 1, 2022 06:20
@veewee
Copy link
Collaborator Author

veewee commented Dec 1, 2022

Changed base branch to 2.3.x (which needs to become the default one), so need a re-accept

@azjezz
Copy link
Owner

azjezz commented Dec 1, 2022

updated default branch 👍

@veewee veewee merged commit 82f241e into azjezz:2.3.x Dec 1, 2022
veewee added a commit to veewee/psl that referenced this pull request Dec 5, 2022
@veewee
Support psalm v5 (azjezz#369)
8cd0ea5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veewee @coveralls @azjezz