Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vec): reproduce and range return type is always non-empty-list #383

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix(vec): reproduce and range return type is always non-empty-list #383

merged 1 commit into from
Dec 20, 2022

Conversation

dragosprotung
Copy link
Contributor

Psl\Vec\reproduce and Psl\Vec\range will always return non-empty-list.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3739265911

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0%) to 99.082%
Totals Coverage Status
Change from base Build 3715024678: -0.0%
Covered Lines: 3779
Relevant Lines: 3814
💛 - Coveralls

@azjezz azjezz self-requested a review December 20, 2022 09:41
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness labels Dec 20, 2022
@azjezz azjezz changed the title Return is always non-empty-list fix(vec): reproduce and range return type is always non-empty-list Dec 20, 2022
@azjezz azjezz added this to the 3.0.0 milestone Dec 20, 2022
@azjezz azjezz merged commit 48d6b71 into azjezz:next Dec 20, 2022
@azjezz
Copy link
Owner

azjezz commented Dec 20, 2022

Thanks @dragosprotung!

@dragosprotung dragosprotung deleted the fix/return-types branch December 20, 2022 09:48
@dragosprotung
Copy link
Contributor Author

@azjezz any chnce to backport this to 2.3.x branch ?

@azjezz
Copy link
Owner

azjezz commented Dec 20, 2022

yep, will do so later today 🤞

azjezz pushed a commit that referenced this pull request Dec 20, 2022
@dragosprotung @azjezz
fix(vec): reproduce and range return type is always non-empty-list (
3ce5e7a 
#383)
@azjezz
Copy link
Owner

azjezz commented Dec 20, 2022

nvm, just did :D https://github.com/azjezz/psl/releases/tag/2.3.1

@dragosprotung
Copy link
Contributor Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@dragosprotung dragosprotung

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dragosprotung @coveralls @azjezz