feat(types): Memoize simple types without arguments #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
commented
Apr 3, 2024
| @@ -98,6 +98,58 @@ public function provideHappyPathCoercion(): array | |||
| 'war' => null, | |||
| ]), | |||
| ], | |||
| 'real-life-type-usage' => [ | |||
There was a problem hiding this comment.
The real-life-type-usage are rather limited
Pull Request Test Coverage Report for Build 8550662461Details
💛 - Coveralls |
azjezz
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks (with
--warmup=20 --revs=200 --retry-threshold=1)The result there is that it has close to zero impact (+ or - 5% which is a matter of nanoseconds) on the regular types, but has a big impact on the
shape()coercions.The
ShapeTypeBenchis the only one that calls multiple types that now get memoized so it represents real-life wins better : In real applications, types tend to repeat more than in the benchmarks.