-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(type): Provides an initial documentation document for the Type component #462
Conversation
great start! could you remove this from |
Pull Request Test Coverage Report for Build 8716607211Details
💛 - Coveralls |
Not sure if we want to keep the same format, as people would most likely read this on GitHub and locally, so maybe we can come up with a better format/style for documentation? |
I can base it on the format in https://github.com/azjezz/psl/blob/next/src/Psl/Async/README.md ? |
2e1d3cb
to
67533ec
Compare
maybe? i don't know really. up to you :D |
739c499
to
a543534
Compare
What do you think about current structure?
I'm also trying to give it a consistent structure:
I tried visualizing this in the documentation website, but can't seem to find a way to visualize it locally. What are you using to display it before pushing it to github? |
6f1a203
to
b6f95eb
Compare
c442732
to
0e82b30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall.
I am still not sure about the format, but, we can keep it as is for now, and if we later decide on a different format, we can change it ( along with the other documentation files ).
Let me know if there is something specific you don't like, I can always change the format.. |
The README is based on the structure in
php-standard-library/php-standard-library.github.io
so that it can be displayed on the website. We concluded to add documentation in this repo, so I am providing it here already.Currently it's an initial draft aiming on explaining what the component can be used for.
It now covers:
I am focussing on providing very detailed types and ideas on how to use them so that we maybe don't need to explain every single type in this package. (like int, float, ...)