Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nonnull type to public namespace #478

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Jun 9, 2024

Currently, the hack in the nonnull type results in a psalm issue when it's being used:

nonnullissue

This PR moves the NonNull type out of the internal namespace to overcome this problem.

@veewee veewee requested a review from azjezz June 9, 2024 16:27
@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9437970726

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 97.228%

Files with Coverage Reduction New Missed Lines %
src/Psl/DateTime/Internal/high_resolution_time.php 2 80.95%
Totals Coverage Status
Change from base Build 9285294552: -0.04%
Covered Lines: 5016
Relevant Lines: 5159

💛 - Coveralls

src/Psl/Type/nonnull.php Outdated Show resolved Hide resolved
@veewee veewee force-pushed the public-type-nonnull branch from df747f2 to 6ac4c14 Compare June 10, 2024 05:11
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9442818277

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.271%

Totals Coverage Status
Change from base Build 9442807174: 0.0%
Covered Lines: 5025
Relevant Lines: 5166

💛 - Coveralls

@veewee veewee merged commit de979c8 into azjezz:next Jun 10, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants