Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove loading of not existing class Interval from Loader #491

Closed
wants to merge 1 commit into from
Closed

Conversation

phpjob
Copy link
Contributor

@phpjob phpjob commented Sep 13, 2024

As mentioned in issue Interval does not existing: #489

Additional to that i executed the preloading, to check if there are more errors.

image

It looks everything is fixed.

@phpjob
Copy link
Contributor Author

phpjob commented Sep 13, 2024

Just to be sure, before i executed php src/preload.php, and got following errors:

PHP Warning:  require_once(/dev/psl/src/Psl/DateTime/Interval.php): Failed to open stream: No such file or directory in /dev/psl/src/Psl/Internal/Loader.php on line 943

Warning: require_once(/dev/psl/src/Psl/DateTime/Interval.php): Failed to open stream: No such file or directory in /dev/psl/src/Psl/Internal/Loader.php on line 943
PHP Fatal error:  Uncaught Error: Failed opening required '/dev/psl/src/Psl/DateTime/Interval.php' (include_path='.:/opt/homebrew/Cellar/php/8.3.11/share/php/pear') in /dev/psl/src/Psl/Internal/Loader.php:943
Stack trace:
#0 /dev/psl/src/Psl/Internal/Loader.php(954): Psl\Internal\Loader::load('Psl/DateTime/In...')
#1 [internal function]: Psl\Internal\Loader::Psl\Internal\{closure}('Psl\\DateTime\\Du...')
#2 /dev/psl/src/Psl/Internal/Loader.php(1011): class_exists('Psl\\DateTime\\Du...')
#3 /dev/psl/src/Psl/Internal/Loader.php(936): Psl\Internal\Loader::loadClasses()
#4 /dev/psl/src/Psl/Internal/Loader.php(960): Psl\Internal\Loader::Psl\Internal\{closure}()
#5 /dev/psl/src/Psl/Internal/Loader.php(932): Psl\Internal\Loader::autoload(Object(Closure))
#6 /dev/psl/src/preload.php(9): Psl\Internal\Loader::preload()
#7 {main}
  thrown in /dev/psl/src/Psl/Internal/Loader.php on line 943

Fatal error: Uncaught Error: Failed opening required '/dev/psl/src/Psl/DateTime/Interval.php' (include_path='.:/opt/homebrew/Cellar/php/8.3.11/share/php/pear') in /dev/psl/src/Psl/Internal/Loader.php:943
Stack trace:
#0 /dev/psl/src/Psl/Internal/Loader.php(954): Psl\Internal\Loader::load('Psl/DateTime/In...')
#1 [internal function]: Psl\Internal\Loader::Psl\Internal\{closure}('Psl\\DateTime\\Du...')
#2 /dev/psl/src/Psl/Internal/Loader.php(1011): class_exists('Psl\\DateTime\\Du...')
#3 /dev/psl/src/Psl/Internal/Loader.php(936): Psl\Internal\Loader::loadClasses()
#4 /dev/psl/src/Psl/Internal/Loader.php(960): Psl\Internal\Loader::Psl\Internal\{closure}()
#5 /dev/psl/src/Psl/Internal/Loader.php(932): Psl\Internal\Loader::autoload(Object(Closure))
#6 /dev/psl/src/preload.php(9): Psl\Internal\Loader::preload()
#7 {main}
  thrown in /dev/psl/src/Psl/Internal/Loader.php on line 943

@phpjob phpjob closed this Sep 13, 2024
@phpjob
Copy link
Contributor Author

phpjob commented Sep 13, 2024

My brain was almost at the weekend 😆 .

I didn't read the comment on the code change in the issue carefully, but only paid attention to deletion 😮‍💨

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10846947437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.654%

Totals Coverage Status
Change from base Build 10824565385: 0.0%
Covered Lines: 5350
Relevant Lines: 5423

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants