Fix get_pdu asking every remote destination even after it finds an …

…event (matrix-org#13346)
azmeuk · Aug 8, 2022 · 3430a0e · 3430a0e
1 parent 04ed45e
commit 3430a0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/13346.misc b/changelog.d/13346.misc
@@ -0,0 +1 @@
+Fix long-standing bugged logic which was never hit in `get_pdu` asking every remote destination even after it finds an event.
diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py
@@ -403,9 +403,9 @@ async def get_pdu(
                         # Prime the cache
                         self._get_pdu_cache[event.event_id] = event
 
-                        # FIXME: We should add a `break` here to avoid calling every
-                        # destination after we already found a PDU (will follow-up
-                        # in a separate PR)
+                        # Now that we have an event, we can break out of this
+                        # loop and stop asking other destinations.
+                        break
 
                 except SynapseError as e:
                     logger.info(