Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 英語入力が日本語入力になってしまう問題を修正 #25

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

ensan-hcl
Copy link
Member

@ensan-hcl ensan-hcl commented Jul 4, 2024

handleDirectInputMode関数を #11 でリファクタリングしたタイミングで、本来関数自体から脱出すべきとこで脱出できないケースが発生していた。このPRではこの問題を修正する。

fix #24

@ensan-hcl ensan-hcl requested a review from nyanko3141592 July 4, 2024 14:29
@ensan-hcl ensan-hcl self-assigned this Jul 4, 2024
Copy link
Collaborator

@nyanko3141592 nyanko3141592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyanko3141592 nyanko3141592 merged commit 05c00cd into main Jul 5, 2024
@nyanko3141592 nyanko3141592 deleted the fix/english_input branch July 5, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 英語入力モードが機能していない
2 participants