Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(virtual_hubs): p2s_config keyvault secret #1841

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(virtual_hubs): p2s_config keyvault secret #1841

merged 1 commit into from
Nov 8, 2023

Conversation

sschne
Copy link
Contributor

@sschne sschne commented Oct 25, 2023 •
edited
Loading

Issue-id

PR Checklist

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@sschne sschne force-pushed the upstream/vhub-p2s-keyvault-certificate branch from 4946f1c to ce2346b Compare October 25, 2023 15:09
@arnaudlh arnaudlh added this to the 5.7.7 milestone Nov 8, 2023
@arnaudlh arnaudlh added enhancement New feature or request virtual wan labels Nov 8, 2023
@arnaudlh arnaudlh self-requested a review November 8, 2023 03:19
arnaudlh
arnaudlh approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 8343019 into aztfmod:main Nov 8, 2023
@arnaudlh
Copy link
Member

arnaudlh commented Nov 8, 2023

thanks for your contribution @sschne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@sschne sschne

Labels
enhancement New feature or request virtual wan
Projects
No open projects
2311
Status: Done
Milestone
5.7.7
Development

Successfully merging this pull request may close these issues.
2 participants
@sschne @arnaudlh