Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support of domain_configuration_type parameter #1889

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

taapawi2
Copy link
Contributor

@taapawi2 taapawi2 commented Dec 15, 2023

PR Checklist


Description

Add support of [domain_configuration_type] (https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/active_directory_domain_service#domain_configuration_type) in the AADDS module.

Edit example configuration by adding the [domain_configuration_type] with "FullySynced"

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh added azuread enhancement New feature or request labels Jan 5, 2024
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added this to the 5.7.8 milestone Jan 8, 2024
@arnaudlh arnaudlh merged commit 8ac739a into aztfmod:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azuread enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants