fix(combined_objects): replace try() with lookup() #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try() tends to introduce inconsistencies when building the resource graph, leading to replacements of resources due to changes in reference maps ( e.g. aztfmod#965 ). This is covering a edge case, when referencing remote_objects from within the same terraform run
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-id
PR Checklist
Description
try() tends to introduce inconsistencies when building the resource graph, leading to replacements of resources due to changes in reference maps ( e.g. #965 ).
This is covering a edge case, when referencing remote_objects from within the same terraform run.
In our particular scenario, we are giving in managed identities into remote_objects for use in AKS, which are previously created due to an known issue #928. When now adding another managed_identity into the remote_objects, we are experiencing a similar force replacement issue as mentioned.
Does this introduce a breaking change
Testing