Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to kuromoji.js 0.1.2: HELP WANTED 🙇 🆘 #8

Closed
16 tasks done
azu opened this issue Dec 21, 2020 · 24 comments
Closed
16 tasks done

Update to kuromoji.js 0.1.2: HELP WANTED 🙇 🆘 #8

azu opened this issue Dec 21, 2020 · 24 comments
Labels
help wanted Extra attention is needed Status: Proposal Request for comments

Comments

@azu
Copy link
Owner

azu commented Dec 21, 2020 •
edited
Loading

kuromoji.js 0.1.2 has a breaking change.

We will update kuromoji.js@0.1.1 → 0.12 as major update kuromojin@3.

After that, we need to update textlint rules that depended on kuromoji@2.
Some rules are broken and we need to fix it!

If you want to help us, please comments!

アップデートのPRを手伝ってくれる人は、どれをやるとかのコメントお願いします。

Plan

  1. Release kuromoji@3 that use kuromoji.js 0.1.2
  2. Update all dependant rules - migrate kuromoji@2 to kuromoji@3
  • If no effect, publish as a minor updates
  • Publish as major updates
  1. Update all presets

Need to update rules

📝 azu/migrate-travis-ci-to-github-actions: Migrate Travis CI to GitHub Actions. Node.js CI settingsを使ってTravis CI → GitHub Actionsもあわせてやるかも。

壊れたルールの例。

https://gist.github.com/azu/8f4435141a5eefe9dcce41a3652ede0b
@azu
Copy link
Owner Author

azu commented Apr 24, 2021

takuyaa/kuromoji.js#23
0.1.1 and 0.1.2 difference results.

@azu
Copy link
Owner Author

azu commented Apr 24, 2021 •
edited
Loading

We need to fix max-ten before updating.

@azu azu mentioned this issue Apr 24, 2021
Closed
@azu azu changed the title Update kuromoji.js Update kuromoji.js 0.1.2: BREAKING CHANGE Apr 24, 2021
@azu azu changed the title Update kuromoji.js 0.1.2: BREAKING CHANGE Update to kuromoji.js 0.1.2: BREAKING CHANGE Apr 24, 2021
@azu azu added help wanted Extra attention is needed Status: Proposal Request for comments labels Apr 24, 2021
@azu azu mentioned this issue Apr 24, 2021
Merged
@azu
Copy link
Owner Author

azu commented Apr 24, 2021 •
edited
Loading

I've released kuromojin@3.0.0.
We will start migration!

https://github.com/azu/kuromojin/releases/tag/v3.0.0

This uses the latest kuromoji.js
https://takuyaa.github.io/kuromoji.js/demo/tokenize.html

DIFF

0.1.2
https://takuyaa.github.io/kuromoji.js/demo/tokenize.html
0.1.1

https://7e32v.csb.app/

This was referenced Apr 24, 2021
Merged
Merged
@azu
Copy link
Owner Author

azu commented Apr 24, 2021 •
edited
Loading

I will take https://github.com/textlint-ja/textlint-rule-no-double-negative-ja

PR: textlint-ja/textlint-rule-no-double-negative-ja#5

@azu
Copy link
Owner Author

azu commented Apr 24, 2021

基本的にmajorアップデートで揃える方が楽かもしれない。
そのあとpresetもmajorアップデートする形

@azu azu mentioned this issue Apr 24, 2021
Merged
@azu
Copy link
Owner Author

azu commented Apr 24, 2021 •
edited
Loading

textlint-ja/analyze-desumasu-dearu: 文の敬体(ですます調)、常体(である調)を解析するJavaScriptライブラリ

I took it.
textlint-ja/analyze-desumasu-dearu#17

@azu
Copy link
Owner Author

azu commented Apr 24, 2021

I took it.
textlint-ja/textlint-rule-no-mix-dearu-desumasu#28 with textlint-ja/textlint-rule-no-mix-dearu-desumasu#28

@azu azu mentioned this issue Apr 24, 2021
Merged
azu added a commit to textlint-ja/textlint-rule-no-mix-dearu-desumasu that referenced this issue Apr 24, 2021
@azu
fix(deps): update to analyze-desumasu-dearu@5 (#28)
43b6833 
## Summary

Update to [analyze-desumasu-dearu v5.0.0](https://github.com/textlint-ja/analyze-desumasu-dearu/releases/tag/v5.0.0)
It includes [kuromojin@3](https://github.com/azu/kuromojin/releases/tag/v3.0.0) and improves analysis.

## Fixes

- update to  [analyze-desumasu-dearu v5.0.0](https://github.com/textlint-ja/analyze-desumasu-dearu/releases/tag/v5.0.0)
- update to [kuromojin@3](https://github.com/azu/kuromojin/releases/tag/v3.0.0)
  - refs azu/kuromojin#8

## CI

- Move to GitHub Actions
@azu
Copy link
Owner Author

azu commented Apr 24, 2021 •
edited
Loading

textlint-ja/textlint-rule-morpheme-match: 形態素解析結果のTokenベースの辞書でマッチするtextlintルール
https://github.com/azu/morpheme-match is library

I took it.

@azu azu pinned this issue Apr 24, 2021
@azu azu changed the title Update to kuromoji.js 0.1.2: BREAKING CHANGE Update to kuromoji.js 0.1.2: HELP WANTED Apr 24, 2021
@azu azu changed the title Update to kuromoji.js 0.1.2: HELP WANTED Update to kuromoji.js 0.1.2: HELP WANTED 🙇 🆘 Apr 24, 2021
This was referenced Apr 24, 2021
Merged
Merged
@azu
Copy link
Owner Author

azu commented Apr 24, 2021 •
edited
Loading

textlint-ja/textlint-rule-ja-no-abusage: よくある日本語の誤用をチェックするtextlintルール

I took it.
textlint-ja/textlint-rule-ja-no-abusage#20

@azu azu mentioned this issue Apr 24, 2021
Merged
@hata6502
Copy link

hata6502/textlint-rule-ja-no-orthographic-variants: 表記ゆれをチェックするtextlintルール
hata6502/textlint-rule-ja-no-inappropriate-words: 不適切表現をチェックするtextlintルール
hata6502/textlint-rule-no-hoso-kinshi-yogo: 放送禁止用語をチェックするtextlintルール

やります。

@azu
Copy link
Owner Author

azu commented Apr 24, 2021

@hata6502 ありがとうございます！
もしよろしければ https://github.com/textlint-ja にリポジトリを移すのもいいかもしれません。
必要ならInviteをお送りします。

@bizen241
Copy link

I will take textlint-ja/textlint-rule-no-dropping-the-ra: ら抜き言葉をチェックするtextlintルール

@azu
Copy link
Owner Author

azu commented Apr 24, 2021

I take textlint-ja/textlint-rule-no-doubled-joshi: 文中に同じ助詞が複数出てくるのをチェックするtextlintルール

This was referenced May 22, 2021
Merged
Merged
Merged
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 6, 2021
Open
Closed
Closed
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this issue Jun 14, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Status: Proposal Request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azu @hata6502 @bizen241