Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpegでの出力にプロセスを使うようにした #961

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

yuto-trd
Copy link
Member

@yuto-trd yuto-trd commented Mar 16, 2024

このプルリクエストで何をやったのか?

今までは音声を生のPCMファイルに保存して、終了時に変換していたが、
一時ファイルが大きくなりすぎるという問題があった。

そこで名前付きパイプを使ったFFmpegラッパーを使って、
順次エンコードするようにした。

タスク

  • コマンドライン引数のオプションを追加

@yuto-trd yuto-trd added the WIP label Mar 16, 2024
@yuto-trd
Copy link
Member Author

Windows以外のOSで WaitForPipeDrain が使えないため、描画が終了するまでメモリ使用量が増えてしまう。

@yuto-trd yuto-trd closed this Mar 18, 2024
@yuto-trd yuto-trd reopened this Mar 25, 2024
@yuto-trd

This comment has been minimized.

@yuto-trd yuto-trd force-pushed the ffmpeg-external-process-output branch from 18749ad to a91180e Compare March 29, 2024 04:02
@yuto-trd yuto-trd merged commit 9e5d04f into main Mar 29, 2024
3 checks passed
@yuto-trd yuto-trd deleted the ffmpeg-external-process-output branch March 29, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant