Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: priority problem #1

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: priority problem #1

merged 3 commits into from
Aug 12, 2024

Conversation

zsystm
Copy link

@zsystm zsystm commented Aug 11, 2024

problem

  • calculation priority is non-deterministic
    • e.g., multiple rounds for future heights and catch up
  • priority is not handled consensus state (no validation for this value, check how Validator set's hash is calculated)

solution

  • (short-term) reset priorities
  • (long-term) treat priority as consensus state

@zsystm zsystm self-assigned this Aug 11, 2024
problem
- calculation priority is non-deterministic
  - e.g., multiple rounds for future heights and catch up
- priority is not handled consensus state (no validation for this value, check how Validator set's hash is calculated)

solution
- (short-term) reset priorities
- (long-term) treat priority as consensus state

note
- resetting target are not decided yet, this is draft
@zsystm zsystm changed the title fix: priority problem (wip) fix: priority problem Aug 11, 2024
zsystm added a commit to b-harvest/Canto that referenced this pull request Aug 11, 2024
@zsystm zsystm mentioned this pull request Aug 11, 2024
10 tasks
default value should be large to existing test codes work correctly
@zsystm zsystm marked this pull request as ready for review August 12, 2024 07:57
@zsystm zsystm merged commit 7a7afcf into v0.34.25-develop Aug 12, 2024
15 of 17 checks passed
zsystm added a commit to b-harvest/Canto that referenced this pull request Aug 12, 2024
* fix: validator priority issue

b-harvest/tendermint#1

* fix: makefile version

* update: default value for flag

* update: go.mod
@zsystm zsystm mentioned this pull request Aug 12, 2024
10 tasks
@dudong2
Copy link

dudong2 commented Aug 12, 2024

Node Operation and Resynchronization Test Scenario

  1. Nodes 1, 2, 3, and 4 are started and running normally.
  2. Nodes 1, 2, and 3 are stopped at block height 10 and then restarted with --reset-priority-height 10. This causes node 4 to proceed with a different priority state compared to the other nodes, leading to continuous invalid proposal signature errors due to the proposer being different from the expected one.
  3. The blockchain proceeds until block 20.
  4. All four nodes (1, 2, 3, and 4) are then stopped and restarted with --reset-priority-height 20.
  5. Finally, verify if the nodes synchronize correctly after the restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants