Skip to content

Commit

Permalink
Update koha-reports-enhancements.md typo
Browse files Browse the repository at this point in the history
  • Loading branch information
b-lawlor authored Sep 19, 2024
1 parent 3dae58e commit e6524b3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions blog/koha-reports-enhancements.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ An existing patch added the ability to optionally add an All option to report pa
A subsequent patch added the option for providing a newline separated list as a report parameter. I started thinking that a newline separated list is essentially a manually created multiselect. If Koha already knows how to handle a list as a report parameter, all we should have to do is make multiselects submit as a single newline delimeted parameter. :dark_sunglasses:
<Bug :id='27380'/>

Standing on the shoulders of Koha giants, I created my first `Frankenhancement`:copyright:, smashing the concepts of these two patches together, sewing its internals up with magical regular expressions and zaping it to life with javascript that overrides the default form submission. It's Alive! :zap: "zombie"
Standing on the shoulders of Koha giants, I created my first `Frankenhancement`:copyright:, smashing the concepts of these two patches together, sewing its internals up with magical regular expressions and zaping it to life with javascript that overrides the default form submission. It's Alive! :zap: :zombie:
<Bug :id='35746'/>

This code has been described as `works well, easy to read, excellent work!`, `feels like hacking` and `hard to maintain` but most importantly `easier than rewriting the whole module`.
Expand All @@ -33,4 +33,4 @@ Pedro spotted a bug in the muti select patch, where if a query contained multipl
<Bug :id='37077'/>

I forgot that earlier I had submitted another enhancement to mutiselect reports based on an improvements made to the item search form. This patch adds the select2 library to make making multi selections in Reports more user friendly. To make this more useful multi selects should really be optional. When no selections are made, report results should not be limnited. To accomplish this I updated the default value of the hidden select to be a newline delimited string of all values.
<Bug :id='37050'/>
<Bug :id='37050'/>

0 comments on commit e6524b3

Please sign in to comment.