19 add orderby #21
Merged
19 add orderby #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 9, 2024 18:26
Rearranged the parameters of 'createAdminRoleServiceBuilder' for better arrangement. Expanded the functions of 'Admin/Contacts/Contacts' and 'Admin/Transactions' to include ordering. Added additional functionalities to 'Core/Command' and 'Core/ApiClient' to accommodate item ordering. Also, made updates to .gitignore and added exceptions for better error handling.
This commit involves the addition of a 'Versions' section in the README.md displaying SDK and PHP versions used, corrections in the order of entities in the implementation of 'Card' strings, and adjustments in the transactions service. It also introduces a new feature that allows users to add new cards, with essential parameters being the card balance, card status, and card percentage. Efficiency in code has been improved through the replacement of several for loops with the more efficient list method, and cleaner code has been achieved through corrections in punctuations in the README.md file. All changes have been documented in the changelog.
The `Fabric` module has been replaced with `IntegrationTestsContextBuilder` in both `CoreTest.php` and `ApiClientTest.php` test suites. This change in test modules enhances the process of setting up the core and the API client before tests are run.
Improved integration testing in admin services for contacts and cards. Added ordering functionality in the list method of both services via 'ItemsOrder' argument. This change also involved updating the available sorting parameters in the README file. Additionally, the Fabric.php file was replaced with IntegrationTestsContextBuilder.php for test setup. Tests and services were also updated to reflect these changes.
The .env file for integration tests has been updated with added values for log file
An ItemsOrder class has been added to support ordering in card fetching functions across different files. The following ordering options are available: creation date, modification date, and balance. The README.md and CHANGELOG.md files have been updated to reflect these changes, and a test for the CardsFetcher class has been added.
This commit adds `count` function to `Contacts` class to get the total number of contacts. It also adds `ContactsFetcher` class for bulk reading of contacts. Changes include necessary tests and updated README.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.