Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short ipv6 format parsing from doc values #1154

Merged
merged 2 commits into from
May 5, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented May 5, 2023

This PR fixes an issue where commit documents could not be parsed when the mergeSource field was requested in the request. ES/Lucene stores the short form of the IP field value even if we use the full long form in the _source. Added a temporary hack to parse into InetAddress which adds zeros to all :: short values and then convert that to RevisionBranchPoint instances.

Related to https://snowowl.atlassian.net/browse/SO-5774

@cmark cmark added bug port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream labels May 5, 2023
@cmark cmark requested review from apeteri and nagyo May 5, 2023 11:54
@cmark cmark self-assigned this May 5, 2023
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@cmark cmark merged commit 9a879b9 into 8.x May 5, 2023
@cmark cmark deleted the issue/short-ipv6-parsing-from-docval branch May 5, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants