Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fhir): Add permission check to FHIR resource update requests #1174

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Jun 16, 2023

Updating a resource requires *:* or edit:* permissions if the user has an associated permissions list (applicable to file, LDAP and JWT token authentication sources).

@apeteri apeteri added the bug label Jun 16, 2023
@apeteri apeteri self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 5.55% and project coverage change: -0.02 ⚠️

Comparison is base (50112cb) 64.05% compared to head (c0e7746) 64.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1174      +/-   ##
============================================
- Coverage     64.05%   64.04%   -0.02%     
- Complexity    12784    12785       +1     
============================================
  Files          1763     1764       +1     
  Lines         59636    59653      +17     
  Branches       5511     5514       +3     
============================================
+ Hits          38201    38203       +2     
- Misses        19058    19074      +16     
+ Partials       2377     2376       -1     
Impacted Files Coverage Δ
...l/fhir/core/request/FhirResourceUpdateRequest.java 0.00% <0.00%> (ø)
...equest/codesystem/FhirCodeSystemUpdateRequest.java 0.00% <0.00%> (ø)
...equest/conceptmap/FhirConceptMapUpdateRequest.java 0.00% <0.00%> (ø)
...re/request/valueset/FhirValueSetUpdateRequest.java 0.00% <0.00%> (ø)
...onal/snowowl/fhir/rest/AbstractFhirController.java 36.36% <0.00%> (-6.88%) ⬇️
...b2international/snowowl/fhir/core/model/Issue.java 95.89% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍏

@nagyo nagyo merged commit e5d4228 into 8.x Jun 21, 2023
@nagyo nagyo deleted the feature/SO-5821-fhir-update-permission-check branch June 21, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants