refactor(snomed.datastore): Improve SnomedDescendantsExpander #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
apeteri
commented
Jul 10, 2023
•
apeteri
commented
- Stream large result sets
- Move total descendant count-only cases to a separate method
- Collect descendant concepts with a search request otherwise
- Use configured limit in SnomedDescendantsExpander
apeteri
force-pushed
the
improvement/snomed-descendants-expand
branch
from
429b363
to
1176d5a
Compare
- Stream large result sets - Move total descendant count-only cases to a separate method - Collect descendant concepts with a search request otherwise - Use configured limit in SnomedDescendantsExpander
apeteri
force-pushed
the
improvement/snomed-descendants-expand
branch
from
1176d5a
to
b364939
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1186 +/- ##
============================================
+ Coverage 64.36% 64.37% +0.01%
- Complexity 13175 13190 +15
============================================
Files 1792 1792
Lines 61436 61503 +67
Branches 5678 5687 +9
============================================
+ Hits 39541 39592 +51
- Misses 19442 19450 +8
- Partials 2453 2461 +8
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.