SO-5834: generic dependency model #1188

cmark · 2023-07-11T15:40:27Z

No description provided.

Old extensionOf and upgradeOf parameters are being converted to the new model and persisted. Support extensionOf/upgradeOf and the new dependency array in all TerminologyResource subtypes.

…encies-model

...dependencies array for backward compatibility

...rnational.snowowl.core/src/com/b2international/snowowl/core/internal/DependencyDocument.java

...from a source URI

codecov · 2023-07-17T14:15:57Z

Codecov Report

Patch coverage: 83.06% and project coverage change: +0.13% 🎉

Comparison is base (7b4c7c2) 64.03% compared to head (13d467b) 64.16%.
Report is 6 commits behind head on 8.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                8.x    #1188      +/-   ##
============================================
+ Coverage     64.03%   64.16%   +0.13%     
- Complexity    12809    12926     +117     
============================================
  Files          1764     1774      +10     
  Lines         59885    60158     +273     
  Branches       5529     5560      +31     
============================================
+ Hits          38348    38602     +254     
- Misses        19157    19174      +17     
- Partials       2380     2382       +2

Files Changed	Coverage Δ
...2international/index/es/query/Es8QueryBuilder.java	`0.00% <0.00%> (ø)`
...ional/snowowl/core/rest/BaseResourceRestInput.java	`85.71% <ø> (ø)`
...snowowl/core/rest/BaseResourceUpdateRestInput.java	`100.00% <ø> (ø)`
...nowowl/core/bundle/BundleSearchRequestBuilder.java	`100.00% <ø> (ø)`
...owowl/core/codesystem/CodeSystemCreateRequest.java	`100.00% <ø> (ø)`
...ore/codesystem/CodeSystemSearchRequestBuilder.java	`100.00% <ø> (ø)`
...owowl/core/codesystem/CodeSystemUpdateRequest.java	`100.00% <ø> (ø)`
...nowowl/core/request/BaseResourceCreateRequest.java	`88.57% <ø> (ø)`
...re/request/resource/BaseResourceSearchRequest.java	`88.59% <ø> (ø)`
...est/resource/BaseResourceSearchRequestBuilder.java	`83.33% <ø> (ø)`
... and 37 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...query string syntax Examples: * ?dependency=codesystems/SNOMEDCT * ?dependency=uri:codesystems/SNOMEDCT OR uri:codesystems/SNOMEDCT/* * ?dependency=uri:codesystems/SNOMEDCT AND scope:extensionOf

...dependency search

...other resources and prevent deletion unless `force` is set to true

...versioned access

apeteri

LGTM!

...work as intended

apeteri

👍

apeteri · 2023-07-24T12:41:01Z

Does snow-owl-ext need a separate PR or is everything handled in classes of this project?

cmark · 2023-07-24T13:41:54Z

Does snow-owl-ext need a separate PR or is everything handled in classes of this project?

There is an open PR in that repo: https://github.com/b2ihealthcare/snow-owl-ext/pull/2681

AAAlinaaa

LGTM

.../com/b2international/snowowl/core/request/resource/BaseTerminologyResourceCreateRequest.java

.../com/b2international/snowowl/core/request/resource/BaseTerminologyResourceUpdateRequest.java

...like settings to make 8.12 backward compatible with pre-8.12 datasets and clients.

cmark added 2 commits July 10, 2023 16:09

feat(core): introduce new dependency model

7878de1

feat(core): migrate resource creation to use the new dependency model

41080cf

Old extensionOf and upgradeOf parameters are being converted to the new model and persisted. Support extensionOf/upgradeOf and the new dependency array in all TerminologyResource subtypes.

cmark added the feature label Jul 11, 2023

cmark requested a review from apeteri July 11, 2023 15:40

cmark self-assigned this Jul 11, 2023

cmark added 7 commits July 12, 2023 14:49

feat(core): allow updating new dependencies field through resource API

8add22f

feat(core): add missing setDependencies method to resource updates req

f64a6cc

Merge remote-tracking branch 'origin/8.x' into feature/SO-5834-depend…

6994c9b

…encies-model

fix(core): properly convert old dependency model values from new...

cb29f83

...dependencies array for backward compatibility

feat(core): add hasQueryPart method to ResourceURIWithQuery

efaf06e

feat(api): support dependencies when creating new codesystems

1be50c6

feat(api): support dependencies when updating existing codesystems

91b380b

apeteri reviewed Jul 17, 2023

View reviewed changes

...rnational.snowowl.core/src/com/b2international/snowowl/core/internal/DependencyDocument.java Show resolved Hide resolved

cmark added 2 commits July 17, 2023 15:13

fix(test): revert upgrade API to use the old model until migration

3fc8a5f

fix(core): properly update dependencies when syncing a codesystem...

ddf5a52

...from a source URI

feat(api): check dependency entry reference integrity before commit

ea8076f

cmark marked this pull request as ready for review July 18, 2023 07:43

cmark requested a review from nagyo July 18, 2023 07:44

cmark added 10 commits July 18, 2023 11:28

feat(api): check dependency entry duplication when creating a resource

88c268d

feat(api): check dependency entries when updating a resource

5ad7e91

feat(index): add support for query_string expression in index layer

4374cfa

feat(core): rename Dependency field resourceUri to uri

852dae8

feat(core): support searching for dependency array entries via...

84d35d0

...query string syntax Examples: * ?dependency=codesystems/SNOMEDCT * ?dependency=uri:codesystems/SNOMEDCT OR uri:codesystems/SNOMEDCT/* * ?dependency=uri:codesystems/SNOMEDCT AND scope:extensionOf

test(core): add test case to verify unversioned and versioned...

05a8fd1

...dependency search

feat(core): check if a resource being deleted is referenced by...

7dc70be

...other resources and prevent deletion unless `force` is set to true

fix(core): scope compare in DependencyDocument

2f4f070

test: remove duplicate codesystem api test

8b9e34c

feat(core): maintain dependencies on version documents for proper...

9f8985a

...versioned access

apeteri approved these changes Jul 21, 2023

View reviewed changes

feat(core): minor Java API changes to ensure third party modules...

5fa02f0

...work as intended

apeteri approved these changes Jul 24, 2023

View reviewed changes

feat(core): make sure resource URIs with queries are recognized properly

04d8961

cmark requested a review from AAAlinaaa July 25, 2023 09:50

AAAlinaaa approved these changes Jul 26, 2023

View reviewed changes

.../com/b2international/snowowl/core/request/resource/BaseTerminologyResourceCreateRequest.java Outdated Show resolved Hide resolved

.../com/b2international/snowowl/core/request/resource/BaseTerminologyResourceUpdateRequest.java Show resolved Hide resolved

cmark added 2 commits July 26, 2023 13:56

fix(core): clarify comment in BaseTerminologyResourceCreateRequest

cbaf364

feat(core): support updating dependencies through other parameters...

13d467b

...like settings to make 8.12 backward compatible with pre-8.12 datasets and clients.

apeteri approved these changes Jul 27, 2023

View reviewed changes

cmark merged commit 6da3d20 into 8.x Jul 27, 2023

cmark deleted the feature/SO-5834-dependencies-model branch July 27, 2023 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SO-5834: generic dependency model #1188

SO-5834: generic dependency model #1188

cmark commented Jul 11, 2023

codecov bot commented Jul 17, 2023 •

edited

Loading

apeteri left a comment

apeteri left a comment

apeteri commented Jul 24, 2023

cmark commented Jul 24, 2023

AAAlinaaa left a comment

SO-5834: generic dependency model #1188

SO-5834: generic dependency model #1188

Conversation

cmark commented Jul 11, 2023

codecov bot commented Jul 17, 2023 • edited Loading

Codecov Report

apeteri left a comment

Choose a reason for hiding this comment

apeteri left a comment

Choose a reason for hiding this comment

apeteri commented Jul 24, 2023

cmark commented Jul 24, 2023

AAAlinaaa left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 17, 2023 •

edited

Loading