Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5363: Do not update Moved from association members during concept... #1243

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

AAAlinaaa
Copy link
Contributor

... reactivation, do not include Moved from replacements for inactive references in quick search widgets, preserve type check in RF2 import

... reactivation, do not include Moved from replacements for inactive
references in quick search widgets, preserve type check in RF2 import
@AAAlinaaa AAAlinaaa self-assigned this Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b076ac6) 62.59% compared to head (5b9f532) 62.60%.
Report is 9 commits behind head on 7.x.

Files Patch % Lines
...ore/request/rf2/validation/Rf2GlobalValidator.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                7.x    #1243   +/-   ##
=========================================
  Coverage     62.59%   62.60%           
- Complexity    11497    11504    +7     
=========================================
  Files          1611     1611           
  Lines         55173    55179    +6     
  Branches       5446     5448    +2     
=========================================
+ Hits          34538    34544    +6     
- Misses        18437    18438    +1     
+ Partials       2198     2197    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark requested a review from apeteri November 20, 2023 10:50
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AAAlinaaa AAAlinaaa requested a review from cmark November 20, 2023 14:44
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit c0e6652 into 7.x Nov 20, 2023
3 of 4 checks passed
@cmark cmark deleted the issue/SO-5363-phase_out_use_of_moved_from_associations branch November 20, 2023 16:35
@AAAlinaaa AAAlinaaa added the port-to-9.x Pull requests that need a complementary PR targeting the 9.x stream label Nov 23, 2023
AAAlinaaa pushed a commit that referenced this pull request Nov 24, 2023
b2ihealthcare/issue/SO-5363-phase_out_use_of_moved_from_associations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-9.x Pull requests that need a complementary PR targeting the 9.x stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants