Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-4122: Implement index schema migrators #1250

Merged
merged 14 commits into from
Dec 12, 2023

Conversation

nagyo
Copy link
Member

@nagyo nagyo commented Dec 12, 2023

No description provided.

nagyo and others added 12 commits December 11, 2023 15:32
- use proper mapping parameter for doCreateIndex()
- add more verbose logging for the whole migration process
- change the naming pattern of temporary index to
`<index>-migrate-to-v<version-number>`
- use small batch size when handling Commit documents
- log reindex results upon successful execution
- add more scenarios to automatically retry reindex operation if
Elasticsearch rejects the attempt due to too many requests
- fall back to v1 for mappings where there is no _meta field present
- use the schema version for the temporary index
...the revision ID field value which ensures that we override the
existing document and not create a new one
@nagyo nagyo requested a review from cmark December 12, 2023 12:30
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (e57082a) 47.96% compared to head (6a19449) 47.95%.
Report is 4 commits behind head on 9.x.

Files Patch % Lines
...ore/version/VersionDocumentSchemaMigratorV9_0.java 0.00% 33 Missing ⚠️
...e/internal/ResourceDocumentSchemaMigratorV9_0.java 0.00% 29 Missing ⚠️
...m/b2international/index/es/admin/EsIndexAdmin.java 73.73% 18 Missing and 8 partials ⚠️
...national/index/revision/DefaultRevisionWriter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1250      +/-   ##
============================================
- Coverage     47.96%   47.95%   -0.01%     
- Complexity    13831    13845      +14     
============================================
  Files          1942     1944       +2     
  Lines         94946    95069     +123     
  Branches      10955    10978      +23     
============================================
+ Hits          45541    45592      +51     
- Misses        46378    46448      +70     
- Partials       3027     3029       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AAAlinaaa AAAlinaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@nagyo nagyo merged commit 1fc2af5 into 9.x Dec 12, 2023
4 of 5 checks passed
@nagyo nagyo deleted the issue/SO-4122_implement_schema_migrators branch December 12, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants