-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO-4122: Implement index schema migrators #1250
Conversation
- use proper mapping parameter for doCreateIndex() - add more verbose logging for the whole migration process - change the naming pattern of temporary index to `<index>-migrate-to-v<version-number>` - use small batch size when handling Commit documents - log reindex results upon successful execution - add more scenarios to automatically retry reindex operation if Elasticsearch rejects the attempt due to too many requests
- fall back to v1 for mappings where there is no _meta field present - use the schema version for the temporary index
...the revision ID field value which ensures that we override the existing document and not create a new one
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1250 +/- ##
============================================
- Coverage 47.96% 47.95% -0.01%
- Complexity 13831 13845 +14
============================================
Files 1942 1944 +2
Lines 94946 95069 +123
Branches 10955 10978 +23
============================================
+ Hits 45541 45592 +51
- Misses 46378 46448 +70
- Partials 3027 3029 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓
No description provided.