Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor FHIR API fixes #1266

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Minor FHIR API fixes #1266

merged 7 commits into from
Mar 18, 2024

Conversation

cmark
Copy link
Member

@cmark cmark commented Mar 14, 2024

This PR fixes a couple of minor issues related to the FHIR R5 API.

Related Jira issues:
https://snowowl.atlassian.net/browse/SO-6058
https://snowowl.atlassian.net/browse/SO-6059
https://snowowl.atlassian.net/browse/SO-5906

@cmark cmark added the bug label Mar 14, 2024
@cmark cmark requested review from apeteri and nagyo March 14, 2024 15:34
@cmark cmark self-assigned this Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 98.48485% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.18%. Comparing base (f8f9efd) to head (d9b8b33).

Files Patch % Lines
...2international/index/es/query/Es8QueryBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1266      +/-   ##
============================================
+ Coverage     48.15%   48.18%   +0.02%     
- Complexity    13879    13896      +17     
============================================
  Files          1944     1944              
  Lines         95031    95063      +32     
  Branches      10976    10980       +4     
============================================
+ Hits          45764    45802      +38     
+ Misses        46270    46267       -3     
+ Partials       2997     2994       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

...wild ECL term description property filters will not fail with index
search exception.

Fixes https://snowowl.atlassian.net/browse/SO-5906
@cmark cmark marked this pull request as ready for review March 18, 2024 13:11
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 8333f0a into 9.x Mar 18, 2024
5 checks passed
@cmark cmark deleted the issue/minor-fhir-api-fixes branch March 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants