Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5916: Search term with ES synonym does not result in a match #1268

Merged
merged 16 commits into from
Mar 20, 2024

Conversation

adamfilep
Copy link
Contributor

No description provided.

@adamfilep adamfilep self-assigned this Mar 19, 2024
@adamfilep adamfilep marked this pull request as ready for review March 20, 2024 12:49
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found two small items but otherwise changes look good!

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 48.18%. Comparing base (f8f9efd) to head (4d1d75c).
Report is 8 commits behind head on 9.x.

❗ Current head 4d1d75c differs from pull request most recent head 07203c8. Consider uploading reports for the commit 07203c8 to get more accurate results

Files Patch % Lines
...b2international/index/es/query/EsQueryBuilder.java 80.00% 4 Missing and 1 partial ⚠️
...c/com/b2international/index/query/Expressions.java 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1268      +/-   ##
============================================
+ Coverage     48.15%   48.18%   +0.03%     
- Complexity    13879    13903      +24     
============================================
  Files          1944     1944              
  Lines         95031    95081      +50     
  Branches      10976    10983       +7     
============================================
+ Hits          45764    45817      +53     
- Misses        46270    46273       +3     
+ Partials       2997     2991       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit 802b50d into 9.x Mar 20, 2024
1 of 2 checks passed
@cmark cmark deleted the issue/SO-5916-syonym-term-search branch March 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants