-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO-5916: Search term with ES synonym does not result in a match #1268
Conversation
Synchronize it with actual default configuration and add extra bits.
...expressions are being built
…rm using... ...synonym" This reverts commit 366771f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓
commons/com.b2international.index.tests/src/com/b2international/index/AnalyzerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found two small items but otherwise changes look good!
commons/com.b2international.index/src/com/b2international/index/es/query/EsQueryBuilder.java
Outdated
Show resolved
Hide resolved
commons/com.b2international.index/src/com/b2international/index/query/TextPredicate.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1268 +/- ##
============================================
+ Coverage 48.15% 48.18% +0.03%
- Complexity 13879 13903 +24
============================================
Files 1944 1944
Lines 95031 95081 +50
Branches 10976 10983 +7
============================================
+ Hits 45764 45817 +53
- Misses 46270 46273 +3
+ Partials 2997 2991 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓
No description provided.