Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ObjectNode fields on ES documents #1274

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Apr 3, 2024

The property index on the field-level annotation Field controls whether it becomes a source-only or a dynamically mapped object in Elasticsearch's mapping. In the latter case top-level properties of the JSON object become searchable.

The "index" property on the field-level annotation controls whether it
becomes a source-only or a dynamically mapped object in Elasticsearch's
mapping.
@apeteri apeteri requested review from cmark and nagyo April 3, 2024 09:50
@apeteri apeteri self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.21%. Comparing base (3566465) to head (6fdec44).
Report is 16 commits behind head on 9.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                9.x    #1274   +/-   ##
=========================================
  Coverage     48.21%   48.21%           
- Complexity    13923    13925    +2     
=========================================
  Files          1946     1946           
  Lines         95122    95122           
  Branches      10985    10985           
=========================================
+ Hits          45860    45861    +1     
  Misses        46269    46269           
+ Partials       2993     2992    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark requested a review from AAAlinaaa April 15, 2024 10:51
@cmark cmark merged commit ecd57ca into 9.x Apr 16, 2024
5 checks passed
@cmark cmark deleted the feature/es-objectnode-mapping branch April 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants